Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved partial profile to a subdirectory #11213

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@evedon
Copy link
Contributor

commented Aug 13, 2019

Description

Moved the partial minimal-printf.json in a subdirectory mbed-os/tools/profiles/extensions because the tools currently don't support partial profiles.
Reverted 3010aaa.
Fixes #11209

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@madchutney @kjbracey-arm

Release Notes

@evedon

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

I need to update the documentation for minimal-printf as well...

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Once approved, we will run exporters at least 2-3x to make sure it is fixed :)

@ciarmcom ciarmcom requested review from kjbracey-arm, madchutney and ARMmbed/mbed-os-maintainers Aug 13, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Scheduled CI now

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 13, 2019

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_pdmc-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

jenkins-ci/mbed-os-ci_pdmc-test

Wrong job configuration, can be ignored. The rest is good

Copy link
Member

left a comment

I don't fully understand profile being in the new place or older but happy to see cproject revert. Starting exporters one more time now

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Exporters run 2x. should be all green on master soon!

@0xc0170 0xc0170 merged commit a64ab31 into ARMmbed:master Aug 14, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8698 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@evedon

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@0xc0170 This PR depends on #11051
So target release should be 5.14

@evedon

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Tag updated to 5.14

Copy link
Contributor

left a comment

Looks like this reverts the previous (breaking) change so ok to me.

@evedon evedon deleted the evedon:partial-profile branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.