Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TT_M3HQ build problem #11237

Merged
merged 3 commits into from Aug 20, 2019

Conversation

@Tharazi97
Copy link
Contributor

commented Aug 16, 2019

Description

This fixes the problem with compiling i2c api, serial api and spi api on TT_M3HQ.

fixes: #11143

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @maciejbocianski

Release Notes

@ciarmcom ciarmcom requested review from jamesbeyond, maciejbocianski and ARMmbed/mbed-os-maintainers Aug 16, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@Tharazi97, thank you for your changes.
@maciejbocianski @jamesbeyond @ARMmbed/mbed-os-maintainers please review.

@jamesbeyond
Copy link
Contributor

left a comment

Toshiba have the same MCU

@jamesbeyond
Copy link
Contributor

left a comment

Can we fix this issue like what Toshiba did, defind macros to cast the object
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_TOSHIBA/TARGET_TMPM3HQ/i2c_api.c#L24-L28

Tharazi97 added 3 commits Aug 16, 2019
Remove SERIAL_FC from target.json on TT_M3HQ
Development board TT_M3HQ doesn't have CTS/RTS on its pinout.
If that is not the case PinMap_UART_RTS should be created.

@Tharazi97 Tharazi97 force-pushed the Tharazi97:TT_M3HQ-build-problem branch from dc86501 to 3c2ed16 Aug 16, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

CI started

@0xc0170 0xc0170 requested a review from jamesbeyond Aug 19, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 19, 2019

@jamesbeyond

This comment has been minimized.

Copy link
Contributor

commented Aug 19, 2019

Hi @MarceloSalazar, could you review the PR, and tag team thundersoft to review as well

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

@ThunderSoft123 Please review

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Fixes nightly, important to get in asap

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

Travis job restarted

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 20, 2019

@0xc0170 0xc0170 merged commit 169ada9 into ARMmbed:master Aug 20, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8593 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.