Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT_CellularSMS: allow configuring SMS encoding (7-bit/8-bit) at initialization #11245

Merged
merged 3 commits into from Aug 23, 2019

Conversation

@dextero
Copy link
Contributor

commented Aug 16, 2019

Description

Currently, AT_CellularSMS contains a _use_8bit_encoding flag that supposedly toggles encoding of sent SMSes. The flag is initialized with false and there is no public API to toggle it.

This pull request makes it possible to select desired encoding when initializing AT_CellularSMS object, and fixes a bug found on the way (PDU buffer size calculation was enough for 7-bit-encoded SMS, but not for 8-bit-encoded ones, resulting in a out-of-bounds access when a long 8-bit SMS was being sent).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Release Notes

AT_CellularSMS::initialize takes an additional encoding parameter that defaults to 7-bit (behavior of existing code does not change, one needs to opt-in to send 8-bit SMS)

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Aug 16, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@dextero, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@bulislaw

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

@AnttiKauppila please review

@jarvte
jarvte approved these changes Aug 22, 2019
@0xc0170 0xc0170 added needs: review and removed needs: review labels Aug 23, 2019
@0xc0170 0xc0170 requested a review from AnttiKauppila Aug 23, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

[x] Functionality change

@AnttiKauppila waiting for your approval, meanwhile start CI

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 23, 2019
@0xc0170 0xc0170 merged commit a1540c5 into ARMmbed:master Aug 23, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-8 bytes) RAM(-72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8700 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.