Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fix BG96 AT driver for IPv6 #11246

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@AriParkkila
Copy link
Contributor

commented Aug 16, 2019

Description

Fix BG96 AT driver to support IPv6 addressing.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica

Release Notes

@ciarmcom ciarmcom requested review from mirelachirica and ARMmbed/mbed-os-maintainers Aug 16, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 19, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

CI started

@@ -57,8 +57,8 @@ static const intptr_t cellular_properties[AT_CellularBase::PROPERTY_MAX] = {
1, // AT_CMGF
1, // AT_CSDH
1, // PROPERTY_IPV4_STACK
0, // PROPERTY_IPV6_STACK

This comment has been minimized.

Copy link
@mirelachirica

mirelachirica Aug 19, 2019

Contributor

This change is causing DNS resolving problems due to the way _stack_type is currently used when BG96 socket is created.
Modem might get only IPv4 address eventhough the PDP context is IPV4V6 and because stack type is set as PDP type => _stack_type set as IPV4V6 => IP_address for the socket opening set to "0:0:0:0:0:0:0:1" => fails to send DNS requests.

_stack_type requires to be set according to the IP address(es) modem is assigned by network. IPV4 for only IPV4 address, IPV6 for only IPV6 address, IPV4V6 when both IPV4 and IPV6 address are assigned by network.

Some kind of fix is needed before we cand do these stack PROPERTY changes since they are breaking the DNS resolving?

This comment has been minimized.

Copy link
@mirelachirica

mirelachirica Aug 19, 2019

Contributor

If nothing else changes, at least (_stack_type == IPV6_STACK) ? "0:0:0:0:0:0:0:1":"127.0.0.1" might be better check than
(_stack_type == IPV4_STACK) ? "127.0.0.1" : "0:0:0:0:0:0:0:1".

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Aug 20, 2019

Member

Anything to address here? I set this to needs: review just in case

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Aug 21, 2019

Member

Once answered (all good?), we can merge

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Aug 21, 2019

Author Contributor

@mirelachirica Please re-review, no more property flag changes in this PR.

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-bg96-ipv6 branch from 1f47a33 to 110fb7d Aug 21, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

CI started

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 22, 2019
@0xc0170 0xc0170 merged commit 88dcf27 into ARMmbed:master Aug 22, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8564 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.