Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT_CellularSMS: set "international" flag in PDU when applicable #11247

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@dextero
Copy link
Contributor

commented Aug 16, 2019

Description

Currently, create_pdu receives a destination address without '+' prefix, and always sets the "type of address" to "unknown". That means, the number needs to contain appropriate international number prefix (00/011) if necessary - which is not the case if the leading + is simply stripped.

This changes send_sms behavior so that when a SMS is sent to an international number (indicated by leading +):

  • AT+CMGS command receives the number with + prefix,
  • created PDU has the "international" flag set in "type of destination address" field.

The change was tested with Quectel BG96 AT modem.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
Currently, create_pdu receives a destination address without '+' prefix,
and always sets the "type of address" to "unknown". That means, the
number needs to contain appropriate international number prefix (00/011)
if necessary - which is not the case if the leading + is simply
stripped.

This changes send_sms behavior so that when a SMS is sent to an
international number (indicated by leading +):

- AT+CMGS command receives the number with + prefix,
- created PDU has the "international" flag set.
@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Aug 16, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@dextero, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@jarvte
jarvte approved these changes Aug 19, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 20, 2019
@0xc0170 0xc0170 merged commit 9ccfe49 into ARMmbed:master Aug 20, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 9563 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

Sitting on top of 5.14 changes so targeting that instead now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.