Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ATHandler::read_int to return 0 successfully #11248

Merged
merged 2 commits into from Aug 29, 2019

Conversation

@dextero
Copy link
Contributor

commented Aug 16, 2019

Description

Currently, ATHandler::read_int is documented to return a positive integer on success, -1 on error. In cases where std::strtol fails to parse a value, 0 is returned - and it is impossible to determine whether that 0 means "parsing failed" or "parsed 0 successfully".

Most places in mbed-os that actually do error checking depend on 0 meaning success, e.g.:

This pull request updates ATHandler::read_int so that it only returns 0 on success, and updates the method comment appropriately.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Aug 16, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@dextero, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@bulislaw

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

@AnttiKauppila please review

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 26, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 27, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@0xc0170 0xc0170 referenced this pull request Aug 28, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

This PR is part of rollup PR #11366

Please do not update this PR, or if needed, let us know asap

@0xc0170 0xc0170 merged commit 726eace into ARMmbed:master Aug 29, 2019
24 of 25 checks passed
24 of 25 checks passed
jenkins-ci/greentea-test Failure
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8630 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.