Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADC internal temperature support and EMAC header fix #11266

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@aqib-ublox
Copy link
Contributor

commented Aug 20, 2019

Description

A pin configuration for Internal temperature sensor attached to ADC1 is added. Header is added to UBLOX EMAC file.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@aqib-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

@0xc0170 EMAC header added and ADC fix also.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Aug 20, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 20, 2019

@aqib-ublox, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@aqib-ublox aqib-ublox changed the title ADc internal temperature suuport and EMAC header fix ADC internal temperature support and EMAC header fix Aug 21, 2019
Copy link
Member

left a comment

Thanks !

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 21, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Fixes #9038

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 22, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@aqib-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

* jenkins-ci/mbed-os-ci_build-ARM

* jenkins-ci/mbed-os-ci_build-IAR

* jenkins-ci/mbed-os-ci_build-GCC_ARM

we have added fix for UBLOX_EVK_ODIN_W2

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

I don't see any new commit here, @aqib-ublox please push an update?

@aqib-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

I don't see any new commit here, @aqib-ublox please push an update?

I am saying we added changes for UBLOX_EVK_ODIN_W2 only. No new commit

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

I see. The compilation errors are valid, can you reproduce?

MODULE_UBLOX_ODIN_W2 is inherited for MBED_CONNECT_ODIN target. But ADC_ are defined only for one of the target, means the rest are failing. Failures look valid to me.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

That is not point (build only for one target), the changes need to build for all targets - all green.

This PR is breaking 2 other targets. To fix, you need to define ADC_ pins added here or make it only for one target (not exposing to others).

@aqib-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

That is not point, the changes need to build for all targets. This PR is breaking 2 other targets. To fix, you need to define ADC_ pins added here or make it only for one target (not exposing to others).

yes agree let me update

@aqib-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

@0xc0170 updated please check and seen changes working for MTB target so decided to update target pins defines

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Aug 23, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 26, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 02d1873 into ARMmbed:master Aug 26, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-1556 bytes) RAM(-64 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8686 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.