Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mbed-coap to version 4.8.1 #11270

Merged
merged 1 commit into from Aug 22, 2019

Conversation

@anttiylitokola
Copy link
Contributor

commented Aug 21, 2019

Description

  • Store ACK's also into duplicate info list.
  • ROM size optimization. Flash size has gone down ~1100 bytes.

Closed issues:

  • IOTCLT-3592 - Client does not handle Duplicate ACK messages during blockwise registration correctly

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@yogpan01, @teetak01

@ciarmcom ciarmcom requested review from teetak01, yogpan01 and ARMmbed/mbed-os-maintainers Aug 21, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@anttiylitokola, thank you for your changes.
@yogpan01 @teetak01 @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@ARMmbed/mbed-os-wan Unittest failure related to this change? [2019-08-21T07:30:17.067Z] 31: mbed assertation failed: obj.timer_id != 0, file: /builds/ws/mbed-os-ci_unittests/unitTest-3649/mbed-os/features/lorawan/system/LoRaWANTimer.cpp, line 57 , please check the logs

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 21, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
@teetak01

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

flaky unittest? This PR cannot impact LoraWAN.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

@anttiylitokola I'll restart the tests, another thing is - is your branch up to date? As the failures are not related to the changeset

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

CI restarted

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

unittest green 💯 CI progressing

Update mbed-coap to version 4.8.1
- Store ACK's also into duplicate info list.
- ROM size optimization. Flash size has gone down ~1100 bytes.

**Closed issues:**
-  IOTCLT-3592 - Client does not handle Duplicate ACK messages during blockwise registration correctly

@anttiylitokola anttiylitokola force-pushed the anttiylitokola:update-mbed-coap-to-4.8.1 branch from e8c634f to 7ba7f7e Aug 21, 2019

@anttiylitokola

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@anttiylitokola I'll restart the tests, another thing is - is your branch up to date? As the failures are not related to the changeset

True, my fork was outdated. Rebased and force pushed.

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 21, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Restarted tests after rebase

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 21, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

cc @ARMmbed/mbed-os-test ^^ internal error in CI, few other jobs have the same one

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 22, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Error resolved, all good here

@0xc0170 0xc0170 merged commit 6812869 into ARMmbed:master Aug 22, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8680 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.