Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCUXpresso Kinetis SPI drive: Add a delay between CS assertion and first sclk edge #11309

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@mmahadevan108
Copy link
Contributor

commented Aug 23, 2019

Description

  1. FPGA test shield requires at least half sclk period delay between CS assertion and first sclk edge
  2. Update Kinetis SPI drivers to match what is already done for K64F

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
…rst sclk edge

1. FPGA test shield requires at least half sclk period delay between
CS assertion and first sclk edge
2. Update Kinetis SPI drivers to match what is already done for K64F

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Aug 23, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 23, 2019

@mmahadevan108, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from mprse Aug 23, 2019
@mprse
mprse approved these changes Aug 26, 2019
Copy link
Member

left a comment

Looks good.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 27, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 29, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 27571bc into ARMmbed:master Aug 29, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8607 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@mmahadevan108 mmahadevan108 deleted the NXPmicro:Fix_Kinetis_Spi branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.