Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating SDP-K1 PinNames.h. #11337

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@malavikasajikumar
Copy link
Contributor

commented Aug 26, 2019

Description

  • Removing LED pin definitions based on color.
  • Removing and updating incorrect USB pin definitions.
  • Adding comments for Arduino SPI and I2C pins.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@maclobdell @0xc0170

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170, maclobdell and ARMmbed/mbed-os-maintainers Aug 26, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

@malavikasajikumar, thank you for your changes.
@0xc0170 @maclobdell @ARMmbed/mbed-os-maintainers please review.

Copy link
Member

left a comment

After spaces are removed, LGTM

LED_RED = LED1,
LED_ORANGE = LED2,
LED_GREEN = LED3,

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Aug 27, 2019

Member

Can you remove pls dead spaces?

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Aug 27, 2019

Member

One more, the commit msg should contain details from the comment here, please add why you are updating the file.

Could be:

SDP-K1: Updating pin names

Removing LED pin definitions based on color.
Removing and updating incorrect USB pin definitions.
Adding comments for Arduino SPI and I2C pins.
@0xc0170 0xc0170 added needs: work and removed needs: review labels Aug 27, 2019
@malavikasajikumar malavikasajikumar force-pushed the malavikasajikumar:master branch from 081aa83 to 421ad37 Aug 27, 2019
- Removing LED pin definitions based on color.
- Removing and updating incorrect USB pin definitions.
- Adding comments for Arduino SPI and I2C pins.
@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

Thank you for the reviews. Fixed them here: malavikasajikumar@db0d3d2

Also, replaced a few tabs in the comments with spaces.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

This PR is part of rollup PR #11366

Please do not update this PR, or if needed, let us know asap

@0xc0170 0xc0170 merged commit db0d3d2 into ARMmbed:master Aug 29, 2019
13 checks passed
13 checks passed
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8701 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.