Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bare-metal configuration to support Pelion Device Management Client #11345

Merged
merged 2 commits into from Aug 28, 2019

Conversation

@yogpan01
Copy link
Contributor

commented Aug 27, 2019

Description

This PR enables Pelion Device Management Client to adapt to bare metal configuration of mbed-os since Client uses nanostack event loop so this component must adhere to bare-metal configuration

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kjbracey-arm please review
PDMC requires event loop to also support bare metal configuration.
It requires to adapt eventloop for bare-metal configuration.
@yogpan01

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@kjbracey-arm please review.

@40Grit

This comment has been minimized.

Copy link

commented Aug 27, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

CI started

@yogpan01

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@0xc0170 This will be required for 5.14 release. Please add necessary labels.

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 27, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Looks like ARM failed due to the changes here: [Error] @0,0: L6218E: Undefined symbol fhss_functions (referred from BUILD/tests/ARCH_MAX/ARM/features/nanostack/mbed-mesh-api/source/wisun_tasklet.o)

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Aug 27, 2019
The bare-metal configuration should be using MBED_CONF_NANOSTACK_CONFIGURATION
instead of MBED_CONF_NANOSTACK_CONFIG.

Fixing the typo for flagging.
@yogpan01

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

@0xc0170 Fixed the failure build, should now build correctly for ARM toolchain as well.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Aug 27, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 27, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Error -11 from IAR, and ARM timeout, restarting to confirm (saw similar issue in another PR).

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 28, 2019

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
@yogpan01

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

@0xc0170 what is the failing cause now? I tried to read the artifact but couldnt decipher the reason for PR check failure.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

Ci restarted

It was the timeout , should be fixed in CI now (not related to this one).

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 28, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 28, 2019
@0xc0170 0xc0170 merged commit a6372e5 into ARMmbed:master Aug 28, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8583 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.