Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for Serial Flash on PSoC Devices #11355

Merged
merged 2 commits into from Aug 30, 2019

Conversation

@kyle-cypress
Copy link

commented Aug 27, 2019

Description

Initial work to support serial flash on PSoC devices. Not exposed by any current targets.
This depends on #11324 and #11323

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Aug 28, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 28, 2019

@kyle-cypress, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

#if defined(CYBSP_ENABLE_FLASH_STORAGE)
/* The linker script allows storing data in external memory, if needed, enable access to that memory. */
cybsp_serial_flash_init();
cybsp_serial_flash_enable_xip(true);

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Aug 28, 2019

Member

isn't XIP enabled via separate PR (@linlingao created earlier)

This comment has been minimized.

Copy link
@morser499

morser499 Aug 28, 2019

Yes, there is another PR on this. This one fixes a couple of other issues, supports multiple targets and all 3 toolchains. The other was focused on the CY8CKIT__062_4343W and GCC.

This comment has been minimized.

Copy link
@morser499

This comment has been minimized.

Copy link
@linlingao

linlingao Aug 28, 2019

Contributor

@morser499 I added a generic mbed config called MBED_CONF_TARGET_XIP_ENABLE so that we can use the same config for non-cypress targets. Does CYBSP_ENABLE_FLASH_STORAGE replace MBED_CONF_TARGET_XIP_ENABLE?

This comment has been minimized.

Copy link
@morser499

morser499 Aug 28, 2019

I think they are intended for the same thing. I think we should use your more generic macro.

This comment has been minimized.

Copy link
@linlingao

linlingao Aug 28, 2019

Contributor

@morser499 Good, I'll override it in #11006 when I rebase.

@kyle-cypress kyle-cypress referenced this pull request Aug 29, 2019
@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 29, 2019
@kyle-cypress kyle-cypress force-pushed the kyle-cypress:pr/psoc-serial-flash branch from a16e465 to d373cab Aug 29, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

CI aborted, will restart after another job

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 30, 2019

Test run: FAILED

Summary: 4 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_unittests
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 30, 2019
@0xc0170 0xc0170 merged commit 335f3ad into ARMmbed:master Aug 30, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-1556 bytes) RAM(-64 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8509 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.