Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32L4 USB device #11402

Merged
merged 3 commits into from Sep 4, 2019

Conversation

@jeromecoutant
Copy link
Contributor

commented Sep 3, 2019

Description

Since ST driver update, USB support was removed.

NB: only Mouse application tested.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@0xc0170

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@jeromecoutant can you run later more tests ? We can meanwhile review, CI. And test as well

cc @jamesbeyond

@0xc0170
0xc0170 approved these changes Sep 3, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

CI started

@bulislaw

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Thanks @jeromecoutant! @jamesbeyond could you please try validating it on one of the L boards we have handy.

@mbed-ci

This comment has been minimized.

Copy link

commented Sep 3, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@ithinuel

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

For future reference, was the pr #11072 ?

@adbridge adbridge added needs: CI and removed needs: review labels Sep 3, 2019
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

For future reference, was the pr #11072 ?

@ithinuel yes that was the PR that removed the support originally

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Also have this strange error:
Doesn't look necessarily related to this PR though ?
@0xc0170 Have you seen this before ?

Image: BUILD/tests/NCS36510/GCC_ARM/TESTS/mbed_platform/stats_thread/stats_thread.hex

Writing FIB: base 0x00003000, size 0x00011EF0, crc32 0x21DECF6A, fw rev 0x01000100, checksum 0x22E01F5A
Not a valid param
Not a valid param
Not a valid param
Not a valid param
Not a valid param
Not a valid param
Not a valid param
Not a valid param
Not a valid param
binf ./BUILD/tests/NCS36510/GCC_ARM/./TESTS/mbed_drivers/ticker/ticker.hex
Memory start 0x00003000, end 0x000104A7
Writing FIB: base 0x00003000, size 0x0000D4A8, crc32 0x7959F68A, fw rev 0x01000100, checksum 0x7A5AFC32
Not a valid param
Not a valid param
Not a valid param
Not a valid param
Not a valid param
Not a valid param
Not a valid param
Not a valid param
Not a valid param

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Will try re-running CI - Restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Sep 3, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 4, 2019
@0xc0170 0xc0170 merged commit 34109f0 into ARMmbed:master Sep 4, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8673 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 removed the ready for merge label Sep 4, 2019
@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_USB_L4 branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.