Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move script to check for floats and make it Python 2 compatible #11429

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@hugueskamba
Copy link
Contributor

hugueskamba commented Sep 6, 2019

Description

All scripts pertaining to example projects tests should be in the same
directory. The test framework uses Python2 therefore this script also needs
to be Python2 compatible.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @evedon

Release Notes

@ciarmcom ciarmcom requested review from evedon, jamesbeyond, maclobdell and ARMmbed/mbed-os-maintainers Sep 6, 2019
@hugueskamba hugueskamba force-pushed the hugueskamba:hk-no-float-validation branch from 22c99f6 to f29cf7c Sep 6, 2019
@0xc0170 0xc0170 removed request for ARMmbed/mbed-os-ipcore and maclobdell Sep 6, 2019
tools/test/examples/examples_lib.py Outdated Show resolved Hide resolved
tools/test/examples/examples.py Outdated Show resolved Hide resolved
tools/test/examples/examples_lib.py Outdated Show resolved Hide resolved
tools/test/examples/examples_lib.py Outdated Show resolved Hide resolved
@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-tools Sep 6, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Sep 6, 2019

There's already conflict, pls rebase

@ARMmbed/mbed-os-tools Please review

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Sep 6, 2019

Please rebase instead of merge (6a9d989 commit)

@hugueskamba hugueskamba force-pushed the hugueskamba:hk-no-float-validation branch from 6a9d989 to 0944477 Sep 6, 2019
@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

hugueskamba commented Sep 6, 2019

Please rebase instead of merge (6a9d989 commit)

@0xc0170
This force-push rebased from master and squashed all commits.

@0xc0170 0xc0170 added the do not merge label Sep 6, 2019
@hugueskamba hugueskamba force-pushed the hugueskamba:hk-no-float-validation branch from 0944477 to f9aadc4 Sep 6, 2019
@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

hugueskamba commented Sep 6, 2019

This force-push removes nanostack-border-router from the list of example projects not to run the floating point post build check as it also currently does not have any floating point operations.

@hugueskamba hugueskamba force-pushed the hugueskamba:hk-no-float-validation branch from 320a8b7 to e230ca1 Oct 18, 2019
@hugueskamba hugueskamba changed the title Test builds with minimal-printf and optional check for floats post-build Move script to check for floats and make it Python 2 compatible Oct 18, 2019
@hugueskamba hugueskamba force-pushed the hugueskamba:hk-no-float-validation branch from e230ca1 to fdf6612 Oct 18, 2019
@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

hugueskamba commented Oct 18, 2019

This force-push removes all changes to examples.py and examples_lib.py as they have been incorporated to #11710.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 18, 2019

CI restarted (aborted old job)

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 18, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

hugueskamba commented Oct 18, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170 I do not believe the failures are caused by the changes in this PR.

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 7
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

@hugueskamba Tests passed in CI but Travis shows python errors, please verify

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Oct 21, 2019
@hugueskamba hugueskamba force-pushed the hugueskamba:hk-no-float-validation branch from fdf6612 to 7871489 Oct 21, 2019
@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

hugueskamba commented Oct 21, 2019

This force-push removes collection unpacking and usages of Python 3.7 f-strings in the Pytest test file to fix the CI error.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Oct 21, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 21, 2019

Test run: FAILED

Summary: 7 of 11 test jobs failed
Build number : 8
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

Aborted ^^

All scripts pertaining to example projects tests should be in the same
directory. The test framework uses Python2 therefore this script also needs
to be Python2 compatible.
@hugueskamba hugueskamba force-pushed the hugueskamba:hk-no-float-validation branch from 7871489 to c712d2f Oct 21, 2019
@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

hugueskamba commented Oct 21, 2019

This force-push removes usage of the pathlib package as it is not listed as a required package in the requirements.txt file of Mbed OS.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 9
Build artifacts

@0xc0170 0xc0170 merged commit 5eeeaca into ARMmbed:master Oct 22, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8677 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@hugueskamba hugueskamba deleted the hugueskamba:hk-no-float-validation branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.