Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add silent option to build #11457

Merged
merged 3 commits into from Oct 21, 2019

Conversation

@OPpuolitaival
Copy link
Contributor

OPpuolitaival commented Sep 11, 2019

Description

Add silent option in test.py and remove some not needed lines. Silent option is need to make CI build faster without logs. If build fails then it will be rebuild with verbose flag. Most of builds success, so then this save time

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@adbridge @madchutney

Release Notes

@OPpuolitaival OPpuolitaival requested review from adbridge and madchutney Sep 11, 2019
Copy link
Contributor

adbridge left a comment

Why is this required? It would be helpful if the PR description explained this.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Sep 11, 2019

Why is this required? It would be helpful if the PR description explained this.

Title should provide be more descriptive plus as well the commits if we add/remove something (to answer there a question "why are these being added/removed").

@OPpuolitaival

This comment has been minimized.

Copy link
Contributor Author

OPpuolitaival commented Sep 11, 2019

Reason added

@0xc0170 0xc0170 requested a review from adbridge Sep 17, 2019
Copy link
Member

0xc0170 left a comment

Mixing few not relevant things but LGTM

@0xc0170 0xc0170 changed the title Py params tools: add silent option to build Sep 17, 2019
Copy link
Contributor

adbridge left a comment

Some general comments for going forward though:

  1. PRs should generally contain only self contained fixes (or certainly in specific commits anyway). Do not mix new changes with general tidy ups etc
  2. Where is the new flag used ? Would be good to have something in the description covering what the knock on effects are of this?
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Sep 17, 2019

While this is in CI, please add details to the above review

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 19, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Sep 20, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Sep 20, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Sep 20, 2019

@mark-edgeworth @madchutney Can you please review if all good here?

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Sep 20, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Sep 20, 2019

It's set as refactor, thus 5.15 ?

@adbridge

This comment has been minimized.

Copy link
Contributor

adbridge commented Sep 27, 2019

@mark-edgeworth @madchutney Can you please review if all good here?

@mark-edgeworth @madchutney bump...

Copy link
Contributor

mark-edgeworth left a comment

Looks ok to me.

@mark-edgeworth

This comment has been minimized.

Copy link
Contributor

mark-edgeworth commented Oct 9, 2019

As this is test code @jamesbeyond may want to comment too...

Copy link
Contributor

jamesbeyond left a comment

--silent already there is the build CLI, this make sense if we have the same CLI option for the test, especially it improves the test performance

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 18, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 18, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 21, 2019
@0xc0170 0xc0170 merged commit 1dac871 into ARMmbed:master Oct 21, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8672 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.