Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert TZ target name to test spec platform name #11467

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@ccli8
Copy link
Contributor

commented Sep 12, 2019

Description

Originally, only the conversion of PSA non-secure target name to test spec platform name is supported for Greentea. This PR extends it by converting all TZ target names to test spec platform name:

  1. All TZ targets should have name pattern: PLATFORM_[PSA_]S/NS, where:
    1. PLATFORM for test spe platform name registered in mbed-os-tools
    2. PSA is optional to distinguish PSA/non-PSA targets, especially when both PSA/non-PSA targets are supported
    3. S/NS for secure/non-secure targets
  2. Secure target may participate in Greentea, so its name is also converted here.

Related PR

Split from #11288

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jamesbeyond

1.  All TZ targets should have name pattern: PLATFORM_[PSA_]S/NS, where:
    (1) 'PLATFORM' for test spec platform name
    (2) 'PSA' is optional to distinguish PSA/non-PSA targets, especially when
        both PSA/non-PSA targets are supported
    (3) 'S'/'NS' for secure/non-secure targets
2. Secure target may participate in Greentea, so its name is also truncated here.
@0xc0170

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Split from #11288

Is this required - dependency ? to understand the release version for this one

@ccli8

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

Is this required - dependency ? to understand the release version for this one

Yes. #11288 depends on this PR.

@ciarmcom ciarmcom requested review from jamesbeyond and ARMmbed/mbed-os-maintainers Sep 12, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@ccli8, thank you for your changes.
@jamesbeyond @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Adding label 5.14.0-rc2

cc @adbridge

@0xc0170

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Sep 12, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 01bb1b9 into ARMmbed:master Sep 12, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-8 bytes) RAM(-72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8670 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_conv_tz_test_spec branch Sep 12, 2019
Copy link
Contributor

left a comment

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.