Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove target dependency in ublox cellular APIs #11580
The intention of this PR is to allow ublox cellular APIs to be used with custom targets.
Pull request type
0xc0170 left a comment
Introducing the new macros, where they are documented ?
Wouldn't be easier to just introduce N211 macro and get U2XX automatically (cellular target header for deduction of the common code) ?
Also please elaborate where am i supposed to document these new macros. Is this supposed to go in Cellular readme or is there some other section for this?
I was just wondering if we can simplify this somehow. Setting two macros for almost the same thing (if we can just use the modem and the family can be found in the header file (although it would mean to maintain the header file to get proper family). So might be after all the same.
Documentation - what types are there and what modems are supported - is it documented anywhere or do I need to scan the sources to find out macros U2XX, etc ?