Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUTURE_SEQUANA: SPI HAL API fixes #11599

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@lrusinowicz
Copy link
Contributor

lrusinowicz commented Sep 30, 2019

Description

Number of fixes for SPI HAL implementation:

  • Fixed miscalculation in SPI frequency setup (divider value).
  • Added possibility to set up SCK line as NC (usable when SPI peripheral
    is used to handle non-SPI protocols.
  • Fixed handling of 16-bit (and other >8 bit) transfers.

tests_sequana_gcc_20190930.log
tests_sequana_blockdevice_gcc_20190930.log

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

- Fixed miscalculation in SPI frequency setup (divider value).
- Added possibility to set up SCK line as NC (usable when SPI peripheral
   is used to handle non-SPI protocols.
- Fixed handlingh of 16-bit (and other >8 bit) transfers.

(cherry picked from commit 7d391f2)
@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Sep 30, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Sep 30, 2019

@lrusinowicz, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@adbridge

This comment has been minimized.

Copy link
Contributor

adbridge commented Oct 7, 2019

@maclobdell please review

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 17, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 17, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 17, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 18, 2019

CI was restarted

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 18, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 18, 2019

client test restarted

@0xc0170 0xc0170 merged commit 734072f into ARMmbed:master Oct 18, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8710 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.