Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOTBTOOL-407 Fix microbit to use Arm C5 #11609

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@madchutney
Copy link
Contributor

madchutney commented Oct 1, 2019

Description

Earlier changes introduced a change to default Arm C6, which does not compile the micro library which is based on Mbed 2. This change fixes the compiler version for NRF51_MICROBIT devices.

https://jira.arm.com/browse/IOTBTOOL-407

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
Earlier changes introduced a change to default Arm C6, which does not compile the micro library which is based on Mbed 2. This change fixes the compiler version for NRF51_MICROBIT devices.
@@ -5318,7 +5318,8 @@
"inherits": ["MCU_NRF51_16K_S110"],
"macros_add": ["TARGET_NRF_LFCLK_RC"],
"release_versions": ["2"],
"device_name": "nRF51822_xxAA"
"device_name": "nRF51822_xxAA",
"supported_toolchains": ["ARMC5", "GCC_ARM"]

This comment has been minimized.

Copy link
@bulislaw

bulislaw Oct 1, 2019

Member

Why only ARMC and GCC and not IAR?

This comment has been minimized.

Copy link
@madchutney

madchutney Oct 2, 2019

Author Contributor

NRF51_MICROBIT inherits from MCU_NRF51_16K_S110 which inherits from MCU_NRF51_S110 and MCU_NRF51_16K_BASE. MCU_NRF51_S110 is a dead end and does not define a toolchain. So following MCU_NRF51_16K_BASE this inherits from MCU_NRF51, which defines the supported_toolchains as [“ARM", "GCC_ARM”]. This means before my change the supported toolchains were Arm C6 and GCC ARM, but before the change which broke microbit they should have been Arm C5 and GCC ARM. This definition seems to be setup in 2016, which means as best as I can tell this platform has never declared support for IAR.

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Oct 14, 2019

Member

I had to check this one as well as I would have assumed nrf51 was supported also by IAR but has not been.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Oct 1, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 1, 2019

@madchutney, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@adbridge adbridge added needs: CI and removed needs: review labels Oct 7, 2019
@adbridge

This comment has been minimized.

Copy link
Contributor

adbridge commented Oct 7, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 7, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@@ -5318,7 +5318,8 @@
"inherits": ["MCU_NRF51_16K_S110"],
"macros_add": ["TARGET_NRF_LFCLK_RC"],
"release_versions": ["2"],
"device_name": "nRF51822_xxAA"
"device_name": "nRF51822_xxAA",
"supported_toolchains": ["ARMC5", "GCC_ARM"]

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Oct 14, 2019

Member

I had to check this one as well as I would have assumed nrf51 was supported also by IAR but has not been.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 14, 2019

Exporters restarted

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 14, 2019

I restarted the entire pipeline accidentally 😞

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 14, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 2fe1468 into ARMmbed:master Oct 15, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+1524 bytes) RAM(+64 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8668 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.