Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum type to align with psa-arch-tests #11620

Merged
merged 1 commit into from Oct 22, 2019
Merged

Conversation

@jainvikas8
Copy link
Contributor

jainvikas8 commented Oct 3, 2019

This is related to #11256
When TARGET_PSA is enabled on Cortex-A boards, the SECURE
is redeclared. So to minimize the impact we can redeclare this in
val.h which is used only by Mbed. And security_t itself is used in
mbed-os\components\TARGET_PSA\TESTS, but the SECURE string is not used.

This is related to #11256
When TARGET_PSA is enabled on Cortex-A boards, the SECURE
is redeclared. So to minimize the impact we can redeclare this in
val.h which is used only by Mbed. And `security_t` itself is used in
mbed-os\components\TARGET_PSA\TESTS, but the SECURE string is not used.

Renamed to `caller_security_t` which aligns with
https://github.com/ARM-software/psa-arch-tests
@jainvikas8 jainvikas8 changed the title Fix enum type to align with psa-arch-tests [WIP] Fix enum type to align with psa-arch-tests Oct 3, 2019
@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Oct 3, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 3, 2019

@jainvikas8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@jainvikas8 jainvikas8 changed the title [WIP] Fix enum type to align with psa-arch-tests Fix enum type to align with psa-arch-tests Oct 3, 2019
@jainvikas8

This comment has been minimized.

Copy link
Contributor Author

jainvikas8 commented Oct 3, 2019

@jamesbeyond Please, could you review it. Thanks.

} security_t;
CALLER_NONSECURE = 0x0,
CALLER_SECURE = 0x1,
} caller_security_t;

This comment has been minimized.

Copy link
@adbridge

adbridge Oct 7, 2019

Contributor

Is this changing actual enumerated types used by a developer ? Or is val.h a test only header file ?

This comment has been minimized.

Copy link
@jainvikas8

jainvikas8 Oct 7, 2019

Author Contributor

val.h is a test only header file.

@0xc0170 0xc0170 requested review from jamesbeyond and adbridge Oct 15, 2019
Copy link
Member

0xc0170 left a comment

Is this breaking change - val.h is included outside of PSA (the application space)?

Copy link
Contributor

jamesbeyond left a comment

In terms of greentea part this PR is OK for me. the changed files actually not part of the GreenTea framework, It is part of PSA Greentea test initialisation code. So the changes will not have impact to other greentea tests.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

@jainvikas8 please confirm this is backward compatible change. I'll start CI meanwhile

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 21, 2019
@jainvikas8

This comment has been minimized.

Copy link
Contributor Author

jainvikas8 commented Oct 21, 2019

@jainvikas8 please confirm this is backward compatible change. I'll start CI meanwhile

There are NO API changes here. It is internal to test only code. So it should be backward compatible.

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 dismissed adbridge’s stale review Oct 22, 2019

Updated

@0xc0170 0xc0170 merged commit 02c722a into ARMmbed:master Oct 22, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8652 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.