Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCellular: Change visibility of _is_connected as protected #11630
Conversation
AT_CellularContext::do_connect() is a virtual API and therefore can be overwritten in inherited class. The problem was that it sets AT_CellularContext::_is_connected flag but earlier it was set as private member making it impossible to set in overwritten do_connect() method. This commit fixes the problem by changing _is_connected as protected enabling its use in inherited class.
This comment has been minimized.
This comment has been minimized.
|
CI started |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Oct 15, 2019
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
This comment has been minimized.
This comment has been minimized.
|
Exporters restarted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kivaisan commentedOct 4, 2019
•
edited
Description
AT_CellularContext::do_connect()is a virtual API and therefore can be overwritten ininherited class. The problem was that it sets
AT_CellularContext::_is_connectedflag butearlier it was set as private member making it impossible to set in overwritten
do_connect()method.
This commit fixes the problem by changing
_is_connectedas protected enabling its usein inherited class.
This is a fix for issue #11606.
Pull request type
Reviewers
@AriParkkila @mudassar-ublox
Release Notes