Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QSPI: document use of QSPI_NO_INST #11691

Merged
merged 1 commit into from Oct 22, 2019

Conversation

@kyle-cypress
Copy link

kyle-cypress commented Oct 15, 2019

Description

Add comments to functions that can take a qspi_inst_t about the value that will cause the instruction phase to be skipped entirely.
This depends on #11604, which introduces the macro in question.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Kyle Kearney
Add comments to functions that can take a qspi_inst_t about the value
that will cause the instruction phase to be skipped entirely.
@kyle-cypress

This comment has been minimized.

Copy link
Author

kyle-cypress commented Oct 15, 2019

Addresses the requested documentation update from #11604 (comment)

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Oct 15, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 15, 2019

@kyle-cypress, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 21, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 22, 2019
@0xc0170 0xc0170 merged commit 9526dad into ARMmbed:master Oct 22, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8670 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.