Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB-Cypress: Lock sleep when USB is initialized #11697

Merged

Conversation

@hugueskamba
Copy link
Contributor

hugueskamba commented Oct 16, 2019

Description

None of the USB drivers currently support entering deep sleep mode
while USB is active. To protect USB from malfunctioning lock deep
sleep in USBPhyHw::init.This is done for similar

This was done for all other implementations as part of
8ffbe5c

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@evedon @c1728p9

Release Notes

@ciarmcom ciarmcom requested review from c1728p9, evedon and maclobdell Oct 16, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 16, 2019

@hugueskamba, thank you for your changes.
@maclobdell @c1728p9 @evedon @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Oct 16, 2019
None of the USB drivers currently support entering deep sleep mode
while USB is active. To protect USB from malfunctioning lock deep
sleep in USBPhyHw::init.This is done for similar

This was done for all other implementations as part of
8ffbe5c
@hugueskamba hugueskamba force-pushed the hugueskamba:hk-fix-lock-deep-sleep-usb-cypress branch from d1683c4 to 7e0b56f Oct 17, 2019
@0xc0170 0xc0170 requested a review from evedon Oct 17, 2019
@0xc0170 0xc0170 requested a review from ARMmbed/team-cypress Oct 25, 2019
@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 25, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 25, 2019

@ARMmbed/team-cypress Please review, we can merge if approved

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 25, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 dismissed evedon’s stale review Oct 25, 2019

Updated

@0xc0170 0xc0170 merged commit 50abaa6 into ARMmbed:master Oct 31, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8648 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@hugueskamba hugueskamba deleted the hugueskamba:hk-fix-lock-deep-sleep-usb-cypress branch Oct 31, 2019
@0xc0170 0xc0170 removed the ready for merge label Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.