Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing os_cb_section #11699

Merged
merged 2 commits into from Oct 18, 2019

Conversation

@rajkan01
Copy link
Contributor

rajkan01 commented Oct 16, 2019

-Added the os_cb_section stub to remove the warnings

Description

Procedure to reproduce the issue:
1.Clone the blinky bare metal from https://github.com/ARMmbed/mbed-os-example-blinky-baremetal.git
2. Compile the blinky bare metal with "mbed compile -t ARMC6 -m target --profile release"
3.End of the compilation you will notice "[Warning] @0,0: L6320W: Ignoring --keep command. Cannot find argument 'os_cb_sections'." warning.

Reason for the issue:

  1. In release profile, ARMC6 compiler have extra optional argument --keep=os_cb_sections but os_cb_section defined inside RTX RTOS(refer mbed-os/rtos)
    2.For bare metal build we dont have RTX RTOS.

Fix for the issue:

  1. Added the osc_cb_section stub to remove the warnings.

This fixes #11565

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@evedon @hugueskamba

Release Notes

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Oct 16, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 16, 2019

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-core Oct 16, 2019
@hugueskamba

This comment has been minimized.

Copy link
Contributor

hugueskamba commented Oct 17, 2019

@rajkan01
Please add the following text to the description so the associated GitHub issue can be automatically closed when this is merged.

This fixes #11565

It will also add a reference of this PR in the GitHub issue.

Could you also provide the steps to reproduce the error before we try your fix?

platform/source/mbed_sdk_boot.c Outdated Show resolved Hide resolved
 -Added the os_cb_section stub to remove the warnings
Incorporated the below review comment
 -Repharase source code comment
@rajkan01 rajkan01 force-pushed the rajkan01:feature-os-cb-section branch from 79147a2 to f3b4eb3 Oct 17, 2019
@evedon
evedon approved these changes Oct 17, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 17, 2019

Travis astyle failed (one space left), please fix

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Oct 18, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 18, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 18, 2019
@0xc0170 0xc0170 merged commit 70f3cf8 into ARMmbed:master Oct 18, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8714 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.