Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CYW9P62S1_43012EVB_01 board #11715

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@miteshdedhia7
Copy link

miteshdedhia7 commented Oct 19, 2019

Description

Add target support for CYW9P62S1_43012EVB_01 board.

Greentea Test Reports:
GT_FT_P6S1_43012EVB_01_GCC.txt
GT_FT_P6S1_43012EVB_01_GCC_NET.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Oct 19, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 19, 2019

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-test Oct 19, 2019
@0xc0170 0xc0170 removed the request for review from ARMmbed/mbed-os-hal Oct 21, 2019
@0xc0170 0xc0170 changed the title Added CYW9P62S1_43012EVB_01 board Add CYW9P62S1_43012EVB_01 board Oct 21, 2019
Copy link
Member

0xc0170 left a comment

Wouldn't be better if the commit "adding this target" contains details about the board. I reviewed the code and wondered why QSPI and some other were removed (how this differs from its parent for instance).

tests-mbed_hal-sleep_manager fails, is this known issue? What about testing other toolchains?

@miteshdedhia7

This comment has been minimized.

Copy link
Author

miteshdedhia7 commented Oct 21, 2019

@0xc0170
tests-mbed_hal-sleep_manager is a known issue for all Cypress targets. The sleep test failures are due to a disconnect in how our sleep APIs and greentea work. GreenTea is continually sending data over the uart, but we prevent going to sleep if there is traffic on the uart. We are investigating workarounds.

I will add details to these details to the commit message but following is the explanation,

  • CRC and TRNG are disabled since the MCU on this board does not have the required hardware.
  • QSPI and QSPIF are temporarily removed due to issues related to supporting the new S25FS512S flash chip we have on this board. These will be enabled as soon as we can get the issues resolved.
    #11722

I will add the test reports for other toolchain as soon as possible.

Notes:
- CRC and TRNG are disabled on this board since the MCU on this board does not have the required hardware.
- QSPI and QSPIF are temporarily removed due to issues related to supporting the new S25FS512S flash chip we have on this board. These will be enabled as soon as we can get the issues resolved.
#11722
@miteshdedhia7 miteshdedhia7 force-pushed the miteshdedhia7:pr/target-cyw9p62s1-43012 branch from fef05b7 to ecdbdc0 Oct 21, 2019
@adbridge

This comment has been minimized.

Copy link
Contributor

adbridge commented Oct 23, 2019

@miteshdedhia7 all our tests must pass before we accept the board....

@0xc0170 0xc0170 requested review from ARMmbed/team-cypress and 0xc0170 Oct 23, 2019
@miteshdedhia7

This comment has been minimized.

Copy link
Author

miteshdedhia7 commented Oct 23, 2019

@0xc0170 The attached greentea report also has the issue #11733. Im re-running the tests on all toolchains again to see if I can get a reliable set of results.

@adbridge tests-mbed_hal-sleep_manager is a failure on all existing Cypress targets. To confirm your comment above is that required to pass for this board to be accepted?

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 24, 2019

@adbridge tests-mbed_hal-sleep_manager is a failure on all existing Cypress targets. To confirm your comment above is that required to pass for this board to be accepted?

To be enabled yes, but to integrate to master - as long as PR is green (it should be as it's not part of PRs testing). It might be in nightly (will be tracked separately if that is the case).

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 24, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 24, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 25, 2019

dynamic test restarted

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 25, 2019

@ARMmbed/team-cypress all good with this target addition?

@miteshdedhia7

This comment has been minimized.

Copy link
Author

miteshdedhia7 commented Oct 25, 2019

A bit too late, but for future reference updated logs for all toolchains,
gcc Greentea
gcc Network Greentea

armc6 Greentea
armc6 Network Greentea

iar Greentea
iar Network Greentea

Additional test failure identified, features-storage-tests-kvstore-static_tests which should be addressed in #11747 since the QSPIF Block is disabled on this device.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 28, 2019

how are tests-integration- failures being tracked?

@miteshdedhia7

This comment has been minimized.

Copy link
Author

miteshdedhia7 commented Oct 28, 2019

@0xc0170 Hi Martin, the tests-integration-* suite tests I believe were added recently in 5.14. We are currently internally working on those being enabled and issues addressed on all cypress targets (I believe these fail for all cypress targets).

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 29, 2019

It might be worth having this as an issue to be able to track it (not only internally).

We shall proceed with this PR

@0xc0170 0xc0170 merged commit 87b150a into ARMmbed:master Oct 29, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8687 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.