Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle legacy process event first on connection complete #11718

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@desmond-blue
Copy link
Contributor

desmond-blue commented Oct 21, 2019

Description

This is a proposed fix for mbed-os-example-ble issue 257.

SM control block doesn't get ready when calling user-defined on_connection_complete process event, so I move the legacy process event forward.

Tested with BLE_SM/BLE_GAP/BLE_Battery/BLE_GattServer on NRF52840_DK.

Updated:
This PR only fix Error during SM::setLinkSecurity 4.
To make BLE SM example work, onAdvertisingEnd() should care if the connection is established, like this mbed-os-example-ble#265 does.

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Oct 21, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 21, 2019

@desmond-blue, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@AGlass0fMilk

This comment has been minimized.

Copy link
Contributor

AGlass0fMilk commented Oct 24, 2019

This does not completely resolve ARMmbed/mbed-os-example-ble#257 when I build that example with this branch.

@desmond-blue

This comment has been minimized.

Copy link
Contributor Author

desmond-blue commented Oct 25, 2019

@AGlass0fMilk You are correct, I didn't state it well.
This PR only fix Error during SM::setLinkSecurity 4.
To make BLE SM example work, onAdvertisingEnd() should care if the connection is established, like this mbed-os-example-ble#265 does.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 25, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 25, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 28, 2019
@0xc0170 0xc0170 merged commit bc2162a into ARMmbed:master Oct 28, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+48 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8690 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.