Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle legacy process event first on connection complete #11718
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
@desmond-blue, thank you for your changes. |
This comment has been minimized.
This comment has been minimized.
This does not completely resolve ARMmbed/mbed-os-example-ble#257 when I build that example with this branch. |
This comment has been minimized.
This comment has been minimized.
@AGlass0fMilk You are correct, I didn't state it well. |
This comment has been minimized.
This comment has been minimized.
CI started |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Oct 25, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
desmond-blue commentedOct 21, 2019
•
edited
Description
This is a proposed fix for mbed-os-example-ble issue 257.
SM control block doesn't get ready when calling user-defined on_connection_complete process event, so I move the legacy process event forward.
Tested with BLE_SM/BLE_GAP/BLE_Battery/BLE_GattServer on NRF52840_DK.
Updated:
This PR only fix
Error during SM::setLinkSecurity 4.
To make BLE SM example work,
onAdvertisingEnd()
should care if the connection is established, like this mbed-os-example-ble#265 does.Reviewers
Release Notes