Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nrf52 i2c byte rw fix #11739

Merged
merged 2 commits into from Oct 28, 2019

Conversation

@maciejbocianski
Copy link
Member

maciejbocianski commented Oct 23, 2019

Description

Fix NRF52 i2c read/write single byte implementation

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jamesbeyond

Release Notes

add tick to us conversion
@ciarmcom ciarmcom requested review from jamesbeyond and ARMmbed/mbed-os-maintainers Oct 23, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 23, 2019

@maciejbocianski, thank you for your changes.
@jamesbeyond @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 24, 2019

@maciejbocianski Can you add details to 627e6de - amend the commit message. There are new private functions added, how they are fixing the problem ,etc.

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:nrf52_i2c_byte_rw_fix branch 4 times, most recently from bd40d7c to b1d0c6e Oct 24, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 25, 2019

@maciejbocianski Can you add details to 627e6de - amend the commit message. There are new private functions added, how they are fixing the problem ,etc.

Any update for this one?

@loverdeg-ep

This comment has been minimized.

Copy link
Contributor

loverdeg-ep commented Oct 25, 2019

i2c_byte_write implementation was broken.
Data sending was inside addressing block

Changed from:
i2c_byte_write
{
   if (start) {
      if (read_address)
         start read;
      esle
         start write;
      write byte;
   }
}

to:
i2c_byte_write
{
   if (start) {
      // if first call after start
      // address for reading or writing
      if (read_address)
         start read;
      esle
         start write;
      } else {
         // send data byte
         write byte;
   }
}
@maciejbocianski maciejbocianski force-pushed the maciejbocianski:nrf52_i2c_byte_rw_fix branch from b1d0c6e to 703348a Oct 28, 2019
@maciejbocianski

This comment has been minimized.

Copy link
Member Author

maciejbocianski commented Oct 28, 2019

@maciejbocianski Can you add details to 627e6de - amend the commit message. There are new private functions added, how they are fixing the problem ,etc.

Any update for this one?

Updated

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 28, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 28, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 28, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 4b21157 into ARMmbed:master Oct 28, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8659 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.