Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the reset_reason host test in the CI #11742

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@fkjagodzinski
Copy link
Member

fkjagodzinski commented Oct 24, 2019

Description

Use a BaseHostTestAbstract.reset() method instead of BaseHostTestAbstract.reset_dut() for more consistent behavior with various platforms in the CI.

In contrast to a local setup, the reset_dut() method flashes the binary again after performing the reset in a remote setup (RaaS). This was not intentional in reset_reason tests. Moreover, this led to a different behavior (a different value of the reset_reason_t enum) for different flashing methods which are target specific.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@TuomoHautamaki, @OPpuolitaival, @jamesbeyond

Release Notes

Use a BaseHostTestAbstract.reset() method instead of
BaseHostTestAbstract.reset_dut() for more consistent behavior with
various platforms in the CI.

In contrast to a local setup, the reset_dut() method flashes the binary
again after performing the reset in a remote setup (RaaS). This was not
intentional in reset_reason tests. Moreover, this led to a different
behavior (a different reset_reason) for different flashing methods which
are target specific.
@ciarmcom ciarmcom requested review from jamesbeyond, OPpuolitaival, TuomoHautamaki and ARMmbed/mbed-os-maintainers Oct 24, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 24, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 25, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 25, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

OPpuolitaival left a comment

Looks good

Copy link
Contributor

jamesbeyond left a comment

LGTM

@0xc0170 0xc0170 merged commit 6f7c1c9 into ARMmbed:master Oct 28, 2019
20 checks passed
20 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8738 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@fkjagodzinski fkjagodzinski deleted the fkjagodzinski:fix-reset_reason-ci_nightly branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.