Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upM2351: Change base target name 'NU_PFM_M2351_CM' to 'NU_PFM_M2351' #11749
Conversation
This is to meet platform name 'NU_PFM_M2351' registered in mbed-os-tools. This tool uses the platform name as a key to search platform related properties in targets.json. For example, the property 'forced_reset_timeout' is critical for Greentea test.
|
The target is private so nothing breaking |
This comment has been minimized.
This comment has been minimized.
|
CI started |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Oct 25, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This was referenced Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ccli8 commentedOct 25, 2019
Description
This PR changes M2351 base target name from
NU_PFM_M2351_CMtoNU_PFM_M2351intargets.json. This is to meet platform nameNU_PFM_M2351registered in mbed-os-tools. This tool uses the platform name as a key to search platform related properties intargets.json. For example, the propertyforced_reset_timeoutis for sync between host and DUT in Greentea test.Known impact
NUSD driver needs modification to support
NU_PFM_M2351target name, like the update.Pull request type