Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlashIAP: Get erase value from HAL instead of hardcoding it #11752

Merged
merged 1 commit into from Oct 28, 2019

Conversation

@mnaberez
Copy link
Contributor

mnaberez commented Oct 26, 2019

Description (required)

Summary of change (What the change is for and why)

When programming flash, if the chunk size to program is less than the page size, the buffer is padded with the erase value. The erase value is hardcoded as 0xFF. However, since #8589, the HAL provides a flash_get_erase_value() function.

This PR replaces the hardcoded 0xFF with the value returned by flash_get_erase_value(). That value will be 0xFF for all existing targets. Removing the hardcoded assumption of 0xFF allows for MBed to support a target with a different erase value, which is the spirit of #8589.

Documentation (Details of any document updates required)

None.


Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR
@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Oct 26, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 26, 2019

@0xc0170 0xc0170 removed the request for review from ARMmbed/mbed-os-test Oct 28, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 28, 2019

CI started

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 28, 2019
@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 28, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 1c5fe1c into ARMmbed:master Oct 28, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8662 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@mnaberez mnaberez deleted the mnaberez:erase-value branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.