Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCypress: fix GPIO mode NONE #11765
Conversation
This comment has been minimized.
This comment has been minimized.
Can you fix "Merge from internal branch (arm-issue-11643)" rather then provide more meaningful commit message. For instance "Cypress: fix gpio mode none" You can add second paragraph to the commit message to describe what you did above about none and strong modes. |
Fix commit msg as requested above |
This comment has been minimized.
This comment has been minimized.
@yarbcy Please let us know once updated |
This comment has been minimized.
This comment has been minimized.
@0xc0170 I fixed commit message. |
This comment has been minimized.
This comment has been minimized.
Ci started |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Oct 30, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This comment has been minimized.
This comment has been minimized.
The CI run only unittests, will check why and should restart |
This comment has been minimized.
This comment has been minimized.
Restarted CI |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Oct 30, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This comment has been minimized.
This comment has been minimized.
CI run entire set, just artifacts are missing |
yarbcy commentedOct 29, 2019
•
edited by 0xc0170
Description (required)
Provide fix for (arm-issue-11643).
#11643
Cypress GPIO pull mode tests fail on CY8CKIT_062_WIFI_B
Summary of change (What the change is for and why)
When PullNone mode, change from CYHAL_GPIO_DRIVE_STRONG -> CYHAL_GPIO_DRIVE_PULL_NONE. Fron now CYHAL_GPIO_DRIVE_PULL_NONE drives CY_GPIO_DM_STRONG when bidirectional or output, CY_GPIO_DM_HIGHZ - when direction is input.
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Reviewers (optional)
Release Notes (required for feature/major PRs)