Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: fix GPIO mode NONE #11765

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@yarbcy
Copy link
Contributor

yarbcy commented Oct 29, 2019

Description (required)

Provide fix for (arm-issue-11643).
#11643
Cypress GPIO pull mode tests fail on CY8CKIT_062_WIFI_B

Summary of change (What the change is for and why)

When PullNone mode, change from CYHAL_GPIO_DRIVE_STRONG -> CYHAL_GPIO_DRIVE_PULL_NONE. Fron now CYHAL_GPIO_DRIVE_PULL_NONE drives CY_GPIO_DM_STRONG when bidirectional or output, CY_GPIO_DM_HIGHZ - when direction is input.

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 29, 2019

Can you fix "Merge from internal branch (arm-issue-11643)" rather then provide more meaningful commit message. For instance "Cypress: fix gpio mode none"

You can add second paragraph to the commit message to describe what you did above about none and strong modes.

Copy link
Member

0xc0170 left a comment

Fix commit msg as requested above

@0xc0170 0xc0170 changed the title Fix for (arm-issue-11643) Cypress: fix GPIO mode NONE Oct 29, 2019
@0xc0170 0xc0170 added the needs: work label Oct 30, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 30, 2019

@yarbcy Please let us know once updated

@yarbcy yarbcy force-pushed the yarbcy:pr/dev-arm-issue-11643 branch from 42edceb to 8055aaa Oct 30, 2019
yarb
@yarbcy yarbcy force-pushed the yarbcy:pr/dev-arm-issue-11643 branch from 8055aaa to 50b0847 Oct 30, 2019
@yarbcy

This comment has been minimized.

Copy link
Contributor Author

yarbcy commented Oct 30, 2019

@0xc0170 I fixed commit message.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 30, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 30, 2019

The CI run only unittests, will check why and should restart

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 30, 2019

Restarted CI

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 31, 2019

CI run entire set, just artifacts are missing

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 31, 2019
@0xc0170 0xc0170 merged commit 0744e67 into ARMmbed:master Oct 31, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8677 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.