Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #11769 (Cypress: PWM FPGA test wrong assert) #11776

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@mprse
Copy link
Member

mprse commented Oct 30, 2019

Description

Implementation of pwmout_read() is not consistent with the requirements.
This function should return the current float-point output duty-cycle in range <0.0f, 1.0f>.
Currently it returns decimal percentage value.

Summary of change

Bug fix.

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@yarbcy @0xc0170


Implementation of pwmout_read() is not consistent with the requirements.
This function should return the current float-point output duty-cycle in range <0.0f, 1.0f>.
Currently it returns decimal percentage value.
@0xc0170 0xc0170 added the needs: CI label Oct 31, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 31, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 31, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 requested a review from ARMmbed/team-cypress Oct 31, 2019
@0xc0170 0xc0170 added needs: review and removed needs: CI labels Oct 31, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 31, 2019

@ARMmbed/team-cypress Please review

@mprse

This comment has been minimized.

Copy link
Member Author

mprse commented Oct 31, 2019

We still need a confirmation from @yarbcy that this fix solves the problem with the failing PWM test.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 31, 2019

Approved by @yarbcy in the issue, good to go

@0xc0170 0xc0170 merged commit aba8f42 into ARMmbed:master Oct 31, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8696 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.