Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOTBTOOL-377: Fix scatter file include path online #11777

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@mark-edgeworth
Copy link
Contributor

mark-edgeworth commented Oct 30, 2019

Description

Fixes an online IDE problem that was preventing any #include paths inside scatter files from being resolved

Summary of change (What the change is for and why)

See the extensive comment in this change for a full description of how this works (and why it didn't)

Documentation (Details of any document updates required)

None

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

This change is a back-ported change which is already in place in the online IDE.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Oct 30, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 30, 2019

@mark-edgeworth, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Member

0xc0170 left a comment

Interesting findings how the online version differs!

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 31, 2019

Ci started meanwhile

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 31, 2019

Test run: FAILED

Summary: 3 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 31, 2019

The job was restarted, thus failure above

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 31, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 31, 2019

@mark-edgeworth Expecting anyone else from @ARMmbed/mbed-os-tools to review this one?

@mark-edgeworth

This comment has been minimized.

Copy link
Contributor Author

mark-edgeworth commented Oct 31, 2019

Probably not; Graham might be interested but he's on vacation until Monday.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 31, 2019

Restarted travis to report the status again

@0xc0170 0xc0170 removed the needs: CI label Oct 31, 2019
@0xc0170 0xc0170 merged commit 764cdcf into ARMmbed:master Oct 31, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8675 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.