Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesnrf52: reset UARTE peripheral in serial_free #11790
Conversation
This comment has been minimized.
This comment has been minimized.
@0xc0170, thank you for your changes. |
This comment has been minimized.
This comment has been minimized.
This doesn't match the description.
I still think |
This comment has been minimized.
This comment has been minimized.
RobVlaar
commented
Nov 1, 2019
•
@0xc0170 can you change this in
|
This comment has been minimized.
This comment has been minimized.
Yes, we should do it. I thought it was in PR or already on master so I took only nrf changes here |
This comment has been minimized.
This comment has been minimized.
@kjbracey-arm shall I add the suggestion to a new PR? |
This comment has been minimized.
This comment has been minimized.
I fixed the title, this is just fixing nrf52 serial_free implementation. @kjbracey-arm please review |
This comment has been minimized.
This comment has been minimized.
CI started |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Nov 13, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170 commentedOct 31, 2019
•
edited
Description (required)
Resolves: #11758
Taken from #11779, thanks @RobVlaar
Summary of change (What the change is for and why)
Add workaround to reset the UARTE peripheral on a destruction of SerialBase to be able to go into deep sleep.
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Reviewers (optional)
@desmond-blue @RobVlaar
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required