Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USBMSD: implement MODE SENSE (10) command #11814

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@sandeepmistry
Copy link
Contributor

sandeepmistry commented Nov 5, 2019

Description (required)

These changes resolve issue #10342.

The mbed-os USB MSD stack was not responding the "MODE SENSE" command causing macOS not to mount the drive.

cc/ @facchinm

Summary of change (What the change is for and why)

Implemented the MODE SENSE 10 USB MSD command which a response based on what CMSIS DAP sends: https://github.com/ARMmbed/DAPLink/blob/master/source/usb/msc/usbd_msc.c#L665-L699

This change allows macOS to successfully mount the mbed-os USB MSD.

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

This was tested with a Arduino Nano 33 BLE board with macOS 10.14.6.


Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes

USBMSD: implement MODE SENSE (10) command

Impact of changes

USBMSD

Migration actions required

N/A

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Nov 5, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 5, 2019

@sandeepmistry, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

4 similar comments
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 5, 2019

@sandeepmistry, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 5, 2019

@sandeepmistry, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 5, 2019

@sandeepmistry, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 5, 2019

@sandeepmistry, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 5, 2019

@sandeepmistry, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
0xc0170 approved these changes Nov 8, 2019
@0xc0170 0xc0170 added needs: CI and removed needs: review labels Nov 8, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 11, 2019
@0xc0170 0xc0170 merged commit a73c2b1 into ARMmbed:master Nov 11, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8652 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.