Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesMCU_LPC11U35_501: fix MCU inheritance #11828
Conversation
This comment has been minimized.
This comment has been minimized.
@0xc0170, thank you for your changes. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@ruevs Please review I'll start CI now |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Nov 12, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
0xc0170 commentedNov 6, 2019
•
edited
Description (required)
Summary of change (What the change is for and why)
This should fix #11652 issue. Use proper inheritance for these targets. Otherwise there are duplicates in the build directory, it won't build.
This is for mbed 2 targets only.
@ruevs Please can you try to download this .json file and replace in your library, if it fixes your issue?
Documentation (Details of any document updates required)
None
Pull request type (required)
Test results (required)
Reviewers (optional)
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required