Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: Add implementation of free() for gpio #11830

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@yarbcy
Copy link
Contributor

yarbcy commented Nov 6, 2019

Fix ARM issue #11746. Cypress: Add implementation of free() for gpio, i2c, analogin

Description (required)

Summary of change (What the change is for and why)

Added implementation of free() function for gpio, i2c, analogin

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes

Added implementation free() functions.

Impact of changes

Cypress

Migration actions required

N/A

@yarbcy yarbcy mentioned this pull request Nov 6, 2019
@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Nov 6, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 6, 2019

@yarbcy, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@mprse

This comment has been minimized.

Copy link
Member

mprse commented Nov 7, 2019

@yarbcy
Great! Can you confirm that adding the implementation of free() solves the problems with FPGA tests?

@0xc0170
0xc0170 approved these changes Nov 7, 2019
@0xc0170 0xc0170 changed the title Fix ARM issue 11746. Cypress: Add implementation of free() for gpio, … Cypress: Add implementation of free() for gpio Nov 7, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 7, 2019

@yarbcy Titles from PRs are used for release notes, I edited to just include what this changes: "Cypress: Add implementation of free() for gpio". If you want to reference PR in the text, add # like this:

Fixes #11746

This shall also be part of the commit message (it is linked to the issue).

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Nov 7, 2019
@yarbcy

This comment has been minimized.

Copy link
Contributor Author

yarbcy commented Nov 7, 2019

@yarbcy
Great! Can you confirm that adding the implementation of free() solves the problems with FPGA tests?

@mprse It solved analogin.

yarbcy pushed a commit to yarbcy/mbed-os that referenced this pull request Nov 7, 2019
@yarbcy yarbcy force-pushed the yarbcy:pr/dev-arm-issue-11746 branch from f617488 to 7f270ae Nov 7, 2019
@yarbcy

This comment has been minimized.

Copy link
Contributor Author

yarbcy commented Nov 7, 2019

@yarbcy Titles from PRs are used for release notes, I edited to just include what this changes: "Cypress: Add implementation of free() for gpio". If you want to reference PR in the text, add # like this:

Fixes #11746

This shall also be part of the commit message (it is linked to the issue).

@0xc0170 Done.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 7, 2019

I already fixed the title, and also edited your first comment. Can you extend the commit msg as it is not just fixing gpio but also 2 more? nit pick :)

I'll run CI asap

@yarbcy yarbcy force-pushed the yarbcy:pr/dev-arm-issue-11746 branch from 7f270ae to e5d31c8 Nov 7, 2019
@yarbcy

This comment has been minimized.

Copy link
Contributor Author

yarbcy commented Nov 7, 2019

I already fixed the title, and also edited your first comment. Can you extend the commit msg as it is not just fixing gpio but also 2 more? nit pick :)

I'll run CI asap

Done.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 7, 2019

CI started

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 7, 2019

I aborted one run (there were 2 runs in the CI)

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 7, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 7, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 7, 2019
@0xc0170 0xc0170 merged commit f3f919e into ARMmbed:master Nov 7, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+24 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8650 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 removed the ready for merge label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.