Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flag checks to allow disabling unsecure tests #11834

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@kivaisan
Copy link
Contributor

kivaisan commented Nov 7, 2019

Description (required)

Fixed checking of configuration for unsecure tests to allow easier disabling of it. Now unsecure tests can be disabled by just removing MBED_CONF_APP_WIFI_UNSECURE_SSID configuration from json (similar to secure tests).

Summary of change (What the change is for and why)
Documentation (Details of any document updates required)

Pull request type (required)

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

This is just a test set up configuration change. In CI both secure and unsecure are tested but after this fix, it is easier to run just secure tests.

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required
Now unsecure tests can be disabled by just removing MBED_CONF_APP_WIFI_UNSECURE_SSID
configuration from json.
@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Nov 7, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 7, 2019

@0xc0170
0xc0170 approved these changes Nov 8, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 8, 2019

CI started

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Nov 8, 2019
@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 8, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 1e43a18 into ARMmbed:master Nov 8, 2019
20 checks passed
20 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8666 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 removed the ready for merge label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.