Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cypress WifiHostDriver to version 1.50 #11840

Merged
merged 2 commits into from Nov 12, 2019

Conversation

@morser499
Copy link

morser499 commented Nov 8, 2019

Description (required)

Update the Cypress Wifi Host Driver (WHD) to version 1.50.

Summary of change (What the change is for and why)

Add support for Manufacturing Test
Update 43012 firmware images
Move WHD from being identified as a Target to being a Component

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

CYW9P62S1_43012EVB_01-GCC_ARM.txt
CYW943012P6EVB_01-GCC_ARM.txt
CY8CKIT_062S2_43012-GCC_ARM.txt
CY8CPROTO_062_4343W-GCC_ARM.txt


Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required
@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Nov 8, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 8, 2019

@morser499, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-ipcore please review.

Copy link
Member

0xc0170 left a comment

Move WHD from being identified as a Target to being a Component

Please send this separately, it's hard to review when you move and change files within one PR. Can this PR be just about updating the driver?

@morser499

This comment has been minimized.

Copy link
Author

morser499 commented Nov 8, 2019

Move WHD from being identified as a Target to being a Component

Please send this separately, it's hard to review when you move and change files within one PR. Can this PR be just about updating the driver?

I don't understand what splitting it up would achieve. Can you clarify? The changes are already split up into separate commits and can be viewed individually:
6c1c1cc

eab475f

Copy link
Contributor

adbridge left a comment

AFAICT the majority of the PR is only changing target code which we do not really review. Someone in the WiFi team may just wish to check the general principle of moving from target to component and the impact on the targets.json file however...

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

SeppoTakalo commented Nov 11, 2019

I think it is OK to move the code to COMPONENTS, if they wish.

I don't see the point of splitting this PR, I would accept this as it is. Looks fine.

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 11, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 11, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 11, 2019

@morser499 Please review build failures

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Nov 11, 2019
@morser499

This comment has been minimized.

Copy link
Author

morser499 commented Nov 11, 2019

@morser499 Please review build failures

Updated BLE feature to use component instead of target as well. The remaining failures appear to be because the MBED_CONF_APP_WIFI_SSID and MBED_CONF_APP_WIFI_PASSWORD are not defined. Did something change in the application related to these values?

@ifyall

This comment has been minimized.

Copy link

ifyall commented Nov 11, 2019

@0xc0170, There is a change in dfa9692 that impacted both MBED_CONF_APP_WIFI_SSID and MBED_CONF_APP_WIFI_PASSWORD. Can that be causing the issue?

Ian

@morser499 morser499 force-pushed the morser499:pr/whd1.50 branch from eab475f to 977cf05 Nov 11, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 12, 2019

@0xc0170, There is a change in dfa9692 that impacted both MBED_CONF_APP_WIFI_SSID and MBED_CONF_APP_WIFI_PASSWORD. Can that be causing the issue?

The next restart will show us, but should not be there (as this is not supported error , not real error but sometimes I noticed it in the logs being printed along iwth the real error).

Restarted CI

@0xc0170 0xc0170 removed the needs: work label Nov 12, 2019
@0xc0170 0xc0170 added the needs: CI label Nov 12, 2019
@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 12, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 12, 2019
@0xc0170 0xc0170 merged commit 609612c into ARMmbed:master Nov 12, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(-72 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8790 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.