Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove ITM Trace support from Arduino Nano 33 BLE #11848
Conversation
This comment has been minimized.
This comment has been minimized.
@manchoz, thank you for your changes. |
This comment has been minimized.
This comment has been minimized.
CI started |
This comment has been minimized.
This comment has been minimized.
mbed-ci
commented
Nov 13, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
manchoz commentedNov 12, 2019
Description
Remove ITM Trace support from Arduino Nano 33 BLE target definition.
Summary of change
Arduino Nano 33 BLE doesn't expose ITM Trace pins which instead are used for external I2C.
When ITM trace is enabled applications need to reset both
CoreDebug->DEMCR
andNRF_CLOCK->TRACECONFIG
in user code to get I2C working.CoreDebug->DEMCR
andNRF_CLOCK->TRACECONFIG
are otherwise configured at SystemInit.This patch removes
ITM
from target features.Pull request type
Test results