New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up: TDBStore no longer requires BlockDevice to have flash behaviour #14007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
Indentifies a PR as containing just a patch
label
Dec 7, 2020
@LDong-Arm, thank you for your changes. |
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
LDong-Arm
force-pushed
the
tdb_no_flash_simulation
branch
from
December 10, 2020 10:03
4505e84
to
9a79c02
Compare
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
evedon
previously approved these changes
Dec 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
LDong-Arm
force-pushed
the
tdb_no_flash_simulation
branch
from
December 11, 2020 14:56
9a79c02
to
b829645
Compare
Rebased |
evedon
approved these changes
Dec 14, 2020
0xc0170
approved these changes
Dec 16, 2020
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.7.0
Release-pending
and removed
release-type: patch
Indentifies a PR as containing just a patch
Release-pending
labels
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Since the merging of #11987,
TDBStore
works with anyBlockDevice
without requiring flash behaviour (i.e. erasing bytes to the erase value,FF
). This PRFlashSimBlockDevice
throughout Mbed OSImpact of changes
None.
Migration actions required
None.
Documentation
ARMmbed/mbed-os-5-docs#1386
(Not interdependent on this PR, but for the same goal)
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-core