Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated clean argument #3538

Merged
merged 1 commit into from Jan 9, 2017
Merged

Remove deprecated clean argument #3538

merged 1 commit into from Jan 9, 2017

Conversation

theotherjimmy
Copy link
Contributor

Description

#3486 removed the clean argument, but forgot to update the build_test

Status

READY

Related PRs

#3486

Todos

  • Tests (export-bulid)

/morph export-build

@theotherjimmy theotherjimmy mentioned this pull request Jan 5, 2017
Merged
1 task
@theotherjimmy
Copy link
Contributor Author

looks like the bot missed the description comment
/morph export-build

@mbed-bot
Copy link

mbed-bot commented Jan 5, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 70

Build Prep failed!

@theotherjimmy
Copy link
Contributor Author

That last one died for reasons unrelated to anything exporter
/morph export-build

@mbed-bot
Copy link

mbed-bot commented Jan 5, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 71

Build Prep failed!

@bridadan
Copy link
Contributor

bridadan commented Jan 5, 2017

Pretty sure I broke this, sorry! I think I have fixed it in CI, let's see:

/morph export-build

@mbed-bot
Copy link

mbed-bot commented Jan 6, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 72

All exports and builds passed!

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 6, 2017 •
edited

Nit: the commit message should contain similar info that description provides here in this PR: #3486 removed the clean argument, but forgot to update the build_test.

LGTM otherwise

@theotherjimmy
Copy link
Contributor Author

So, what work is needed?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 9, 2017

So, what work is needed?

LGTM as it is

@sg- sg- merged commit ff49a8c into ARMmbed:master Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@theotherjimmy @mbed-bot @bridadan @0xc0170 @sg-