New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 remove warning in hal_tick_32b.c file #3741

Merged
merged 1 commit into from Mar 6, 2017

Conversation

Projects
None yet
5 participants
@jeromecoutant
Contributor

jeromecoutant commented Feb 10, 2017

Description

Remove warning in TARGET_STM/hal_tick_32b.c
Add debug capability
Astyle run

Status

READY

@sg-

This comment has been minimized.

Member

sg- commented Feb 13, 2017

I'd prefer we add a unified debug method before taking this. Sure there are examples where this exists but I'd suggest we dont take more, rather, start a common implementation.

@sg- sg- added the needs: work label Feb 13, 2017

@bridadan

This comment has been minimized.

Contributor

bridadan commented Feb 14, 2017

retest uvisor

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 15, 2017

I restarted travis as I could not see the failure. @jeromecoutant please have a look once it finishes.

Regarding debug msg, I would leave it out from this patch. As written in another PR, we should have a generalized API for that, so alll of us can benefit from it. Please create an issue and we should have a look at it.

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_TICK32 branch Feb 21, 2017

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_TICK32 branch to 0259c1a Feb 21, 2017

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Feb 21, 2017

Debug messages have been removed, and rebase done.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2017

Debug messages have been removed, and rebase done.

Thanks !

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Feb 21, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Feb 21, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1668

All builds and test passed!

@bridadan bridadan added needs: review and removed needs: CI labels Feb 22, 2017

@bridadan

This comment has been minimized.

Contributor

bridadan commented Feb 22, 2017

I'm guessing because this is such a minor change that we don't have to review much, but the final call is up to you @0xc0170 😄

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Mar 2, 2017

Forgot to merge ? :-)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 2, 2017

Forgot to merge ? :-)

Looks like that . I;'ll reapply a label to a new release version. Thanks for the reminder

@0xc0170 0xc0170 merged commit 750ac51 into ARMmbed:master Mar 6, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_TICK32 branch Mar 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment