New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bd: Add randomness to block device test and more debug friendly output #3747

Merged
merged 2 commits into from Mar 22, 2017

Conversation

Projects
None yet
6 participants
@geky
Member

geky commented Feb 11, 2017

Added to block device test during debug of SPIFBlockDevice and I2CEEBlockDevice. Currently this tests is duplicated for all block devices.

  • Uses rand to select pseudorandom blocks, slightly better coverage and no longer will intensively wear block zero.
  • Added nice printing of sizes
  • Added preview of read/write data for debugging
  • Added an error mask of where errors occured in block for debugging
@simonqhughes

This comment has been minimized.

Contributor

simonqhughes commented Feb 13, 2017

Please could you take a look at the heap_block_device/main.cpp error at:

https://jenkins-internal.mbed.com/job/ARMmbed/job/mbed-os/job/PR-3747/1/consoleFull

[K64F ARM] Build failures:
[K64F ARM]   * K64F::ARM::FEATURES-TESTS-FILESYSTEM-HEAP_BLOCK_DEVICE
[K64F ARM]         Building project heap_block_device (K64F, ARM)
[K64F ARM]         Scan: ARM
[K64F ARM]         Scan: FEATURE_LWIP
[K64F ARM]         Scan: FEATURE_STORAGE
[K64F ARM]         Scan: heap_block_device
[K64F ARM]         Compile [100.0%]: main.cpp
[K64F ARM]         [Error] main.cpp@50,0:  #308: more than one instance of overloaded function "log" matches the argument list:
[K64F ARM]         [Error] main.cpp@50,0:  #308: more than one instance of overloaded function "log" matches the argument list:
[K64F ARM]         
[K64F ARM] [mbed] ERROR: "python" returned error code 1.
[K64F ARM] [mbed] ERROR: Command "python -u /builds/ws/ARMmbed/mbed-os/PR-3747/mbed-os/tools/test.py -t ARM -m K64F -c --source /builds/ws/ARMmbed/mbed-os/PR-3747/mbed-os --build /builds/ws/ARMmbed/mbed-os/PR-3747/mbed-os/BUILD/tests/K64F/ARM --test-spec /builds/ws/ARMmbed/mbed-os/PR-3747/mbed-os/BUILD/tests/K64F/ARM/test_spec.json" in "/builds/ws/ARMmbed/mbed-os/PR-3747/mbed-os"
[K64F ARM] ---

@geky

@geky geky force-pushed the geky:bd-verbose-test branch 2 times, most recently Feb 13, 2017

@geky

This comment has been minimized.

Member

geky commented Feb 13, 2017

Ah, multiple float/double overloads for the math functions caused inference problems when passed ints.

Should be updated 👍

@simonqhughes

As the KL25Z IAR MBED_STACK_STATS_ENABLED handling has been backed out, we need to check CI for this case builds.

@bridadan

This comment has been minimized.

Contributor

bridadan commented Feb 16, 2017

retest uvisor

@sg-

This comment has been minimized.

Member

sg- commented Feb 17, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Feb 17, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1630

Test failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 20, 2017

please look at failures. Some seems to be legitimate. I'll rerun it, because some seem to be not relevant to this patch.

This patch might affect integration of this branch to master #3762

/morph test-nightly

@bridadan

This comment has been minimized.

Contributor

bridadan commented Feb 20, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Feb 20, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1658

Example Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2017

One example for nucleo and for only IAR, please have a look

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 27, 2017

Any update for this?

@geky

This comment has been minimized.

Member

geky commented Feb 27, 2017

Will update, there's a bit of work to match last minute changes to the block device api

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 6, 2017

Will update, there's a bit of work to match last minute changes to the block device api

Any update?

@geky geky force-pushed the geky:bd-verbose-test branch Mar 7, 2017

@geky geky changed the base branch from feature-storage to master Mar 7, 2017

@geky

This comment has been minimized.

Member

geky commented Mar 7, 2017

Updated and rebased against master, although this will have a merge conflict with #3866 because of stupid C++ rules regarding implicit casts of const member function pointers... : (

@geky

This comment has been minimized.

Member

geky commented Mar 7, 2017

@bridadan, this also removes the ifdefs preventing tests from running on small devices (no longer an issue).

@bridadan

This comment has been minimized.

Contributor

bridadan commented Mar 7, 2017

@bridadan, this also removes the ifdefs preventing tests from running on small devices (no longer an issue).

This makes me a very happy 🐼

@simonqhughes

This comment has been minimized.

Contributor

simonqhughes commented Mar 8, 2017

Looks good to me. Lets merge.

@geky

This comment has been minimized.

Member

geky commented Mar 8, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 8, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1657

Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 9, 2017

Please look at the failures

@geky geky force-pushed the geky:bd-verbose-test branch Mar 9, 2017

@geky

This comment has been minimized.

Member

geky commented Mar 9, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 10, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1668

Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 10, 2017

18:03:22         [Error] main.cpp@39,1: cannot convert 'bd_size_t (BlockDevice::*)() const {aka long long unsigned int (BlockDevice::*)() const}' to 'bd_size_t (BlockDevice::*)() {aka long long unsigned int (BlockDevice::*)()}' in initialization

All build fails due to error in the test, see above

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Mar 10, 2017

@geky geky force-pushed the geky:bd-verbose-test branch to 704c94d Mar 10, 2017

@geky

This comment has been minimized.

Member

geky commented Mar 10, 2017

I did call it, though I forgot this would happen.

Should be updated

@geky

This comment has been minimized.

Member

geky commented Mar 10, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 10, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1674

All builds and test passed!

@bridadan bridadan added needs: review and removed needs: work labels Mar 10, 2017

@bridadan

This comment has been minimized.

Contributor

bridadan commented Mar 10, 2017

Results look good!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 13, 2017

@simonqhughes Please review

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 20, 2017

@simonqhughes Please review

Any update?

@sg- sg- merged commit 9677218 into ARMmbed:master Mar 22, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test-nightly Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment