New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32L476xG: set APB2 clock to 80MHz (instead of 40MHz) #3843

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
4 participants
@bcostm
Contributor

bcostm commented Feb 27, 2017

Description

The APB2 clock was not set to the maximum possible value (80 MHz). The SPI clock can now go up to 40 MHz.

Discussion started in Issue #3735.

Status

READY

Migrations

NO

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 28, 2017

How was this tested?

@bcostm

This comment has been minimized.

Contributor

bcostm commented Mar 1, 2017

I checked the SPI clock with a scope on L476RG device.

@helmut64

This comment has been minimized.

Contributor

helmut64 commented Mar 1, 2017

Good morning, I tested the change by embedding it into my development.
The scope shows now the SCLK with 40 MHz instead and 20 MHz.

My SPI Winbond flash works as expected:
00:21:44.375473 FlashReadTest: number of reads: 1024 (each 4096 bytes), Rounds: 1
00:21:44.375792 Round: 1 Sector: 0
00:21:45.593603 Round: 1 Sector: 100
...
00:21:47.549900 Round: 1 Sector: 1000
4194304 bytes, 2227 ms, 1.80 MB/sec

The change works fine for me.
Regards Helmut

@bcostm (off topic), I did an code enhancements in the STM HAL_SPI_TransmitReceive function. It is not much, how can I provide my change to you/STM?

@bcostm

This comment has been minimized.

Contributor

bcostm commented Mar 1, 2017

Thanks Helmut for the testing.

Concerning you HAL SPI change, please send a PR and we'll have a look into it. Thanks.

@bcostm bcostm changed the title from STM32L4xx: set APB2 clock to 80MHz (instead of 40MHz) to STM32L476xG: set APB2 clock to 80MHz (instead of 40MHz) Mar 1, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 1, 2017

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 1, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 1, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1610

All builds and test passed!

@bcostm bcostm force-pushed the bcostm:fix_stm32l4_apb2_80MHz branch to ae6899b Mar 6, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 6, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 6, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1642

All builds and test passed!

@0xc0170 0xc0170 merged commit 68dc253 into ARMmbed:master Mar 9, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bcostm bcostm deleted the bcostm:fix_stm32l4_apb2_80MHz branch Mar 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment