New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: change spi error to debug warning #3850

Merged
merged 1 commit into from Mar 6, 2017

Conversation

Projects
None yet
4 participants
@LMESTM
Contributor

LMESTM commented Feb 28, 2017

This is the proposed fix to issue #3849

Description

In case the selected frequency is higher than the requested one, it is
better to send a debug warning rather than an blocking error.

In case of such warning, user may need to redefine the clock tree setting
at higher level (reducing peripheral's input clocks during init phase).

This will avoid to block basic operations that would work anyway with a frequency higher than the requested one.

STM32: change spi error to debug warning
In case the selected frequency is higher than the requested one, it is
better to send a debug warning rather than an blocking error.

In case of such warning, user may need to redefine the clock tree setting
at higher level (reducing peripheral's input clocks during init phase).
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 28, 2017

cc @c1728p9 - please review

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Feb 28, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Feb 28, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1608

All builds and test passed!

@0xc0170

0xc0170 approved these changes Mar 1, 2017

@0xc0170 0xc0170 merged commit e6b8ed2 into ARMmbed:master Mar 6, 2017

5 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment