New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCS36510: Default range changed from 0 to 950mV - ADC #3869

Merged
merged 3 commits into from Mar 14, 2017

Conversation

Projects
None yet
4 participants
@radhika-raghavendran
Contributor

radhika-raghavendran commented Mar 2, 2017

now the range is 0 to 3.3V

Notes:

  • Pull requests will not be accepted until the submitter has agreed to the contributer agreement.
  • This is just a template, so feel free to use/remove the unnecessary things

Description

The default range of ADC was 0 to 950mV. Now it has been changed to 0 to 3.3V.

Status

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

YES | NO

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Todos

  • Tests
  • Documentation

Deploy notes

Notes regarding the deployment of this PR. These should note any
required changes in the build environment, tools, compilers, etc.

Steps to test or reproduce

Attached are the green tea test results
ARM_Results-02-03-2017.txt

@radhika-raghavendran radhika-raghavendran changed the title from Default range changed from 0 to 950mV - ADC to NCS36510: Default range changed from 0 to 950mV - ADC Mar 2, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 6, 2017

Any test run, like ci test shield to exercise ADC ?

@0xc0170 0xc0170 added the needs: CI label Mar 6, 2017

@0xc0170

0xc0170 approved these changes Mar 6, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 6, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 6, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1643

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 7, 2017

@radhika-raghavendran

This comment has been minimized.

Contributor

radhika-raghavendran commented Mar 9, 2017

Adding the definitions for A4 and A5 ADC pins.
They are not connected on the NCS36510 board; defined as NC in the file PinNames.h

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 9, 2017

Please once again rebase (that should remove all those commits from this PR that are already on master)

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Mar 9, 2017

@radhika-raghavendran radhika-raghavendran force-pushed the radhika-raghavendran:master branch to c06fa3a Mar 9, 2017

@radhika-raghavendran

This comment has been minimized.

Contributor

radhika-raghavendran commented Mar 9, 2017

I have rebased and picked only the latest change.
Can you please verify and let me know if it is ok?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 9, 2017

Can you please verify and let me know if it is ok?

Rebase looks good but I dont see previous change for ADC. Only pins NC for A4/A5 (they are unaligned in the file). Why adc changes were removed?

@radhika-raghavendran

This comment has been minimized.

Contributor

radhika-raghavendran commented Mar 10, 2017

@0xc0170 The previous change was lost during the rebase and cherry pick. I have redone the change.
I hope it works this time :)

@@ -59,6 +60,8 @@ typedef enum {
A1,
A2,
A3,
A4 = NC,

This comment has been minimized.

@0xc0170

0xc0170 Mar 10, 2017

Member

Nit: used tabs as its misaligned? Can you fix it?

@0xc0170

LGTM (just that one style misalignment)

@radhika-raghavendran

This comment has been minimized.

Contributor

radhika-raghavendran commented Mar 10, 2017

@0xc0170 Changed the misaligned style.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 10, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 10, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 10, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1671

All builds and test passed!

@adbridge adbridge merged commit 538e160 into ARMmbed:master Mar 14, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment