New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_F469NI: allow the use of CAN2 instance when CAN1 is not activated #3880

Merged
merged 1 commit into from Mar 6, 2017

Conversation

Projects
None yet
4 participants
@adustm
Member

adustm commented Mar 3, 2017

Description

On STM32F4 family, the CAN2 hw instance is using CAN1's filters.
HAL_CAN1_CLOCK_ENABLE must be activated.
This modification is not impacting other STM32 families behavior

Status

READY

Migrations

NO

Steps to test or reproduce

Use the can autoloop test with only CAN2 activated on DISCO_F469NI
(test name MBED_A27, with CAN can1(PB_5, PB_13); instead of CAN can1(PB_8, PB_9);)
Without the patch, thecan.readdoes not work (only write works) and MBED_A27 test is failed
With the patch, can.read works and MBED_A27 test is a success

@0xc0170

0xc0170 approved these changes Mar 6, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 6, 2017

/morph test

@0xc0170 0xc0170 added the needs: CI label Mar 6, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 6, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

@adustm

This comment has been minimized.

Member

adustm commented Mar 6, 2017

Hello @0xc0170
Could you give me details about the CI/morph-test failure ? Let me know if I need to change something.
Kind regards

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 6, 2017

Java exception, not related to this patch I believe. Restarting

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 6, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

@bridadan

This comment has been minimized.

Contributor

bridadan commented Mar 6, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 6, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1637

All builds and test passed!

@0xc0170 0xc0170 merged commit b272647 into ARMmbed:master Mar 6, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adustm adustm deleted the adustm:fix_can2_only branch Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment