New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NRF51822] Fix reference to sleep in hal_patch override #3913

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
5 participants
@pan-
Member

pan- commented Mar 9, 2017

Description

The sleep function as been changed into hal_sleep by #3607.
Unfortunately the call to sleep in the hal_patch for the NRF51822 has not been
updated to hal_sleep. The result was a link time error for targets based on
NRF51822_LEGACY compiling with the mbed OS 5 tree.

Status

READY

Migrations

NO

[NRF51822] Fix reference to sleep in hal_patch override
The `sleep` function as been changed into `hal_sleep` by #3607.
Unfortunately the call to `sleep` in the hal_patch for the NRF51822 has not been
updated to `hal_sleep`. The result was a link time error for targets based on
NRF51822_LEGACY compiling with the mbed OS 5 tree.
@pan-

This comment has been minimized.

Member

pan- commented Mar 9, 2017

@nvlsianpu @anangl Could you review this PR and ensure that the change in this PR is correctly reported to the NRF51822 BLE implementation on developer.mbed.org ?

@0xc0170

0xc0170 approved these changes Mar 9, 2017

@pan- pan- added the devices: nordic label Mar 9, 2017

@nvlsianpu

This comment has been minimized.

Contributor

nvlsianpu commented Mar 9, 2017

It looks properly.

@pan-

ensure that the change in this PR is correctly reported to the NRF51822 BLE implementation on developer.mbed.org ?

Should I expected that you are going to update nRF51822 mbed 2.0 support repos?

@anangl

anangl approved these changes Mar 9, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 9, 2017

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 9, 2017

@pan-

This comment has been minimized.

Member

pan- commented Mar 9, 2017

Should I expected that you are going to update nRF51822 mbed 2.0 support repos?

@nvlsianpu I think mbed 2 repo should be in line with the implementation in mbed-os. The question is who does it.

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 9, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1664

All builds and test passed!

@0xc0170 0xc0170 merged commit 8edeea7 into ARMmbed:master Mar 9, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pan- pan- deleted the pan-:NRF51-fix-sleep-override branch Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment