New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake register setting in serial_format() #3917

Merged
merged 1 commit into from Mar 14, 2017

Conversation

Projects
None yet
4 participants
@TomoYamanaka
Contributor

TomoYamanaka commented Mar 10, 2017

Currently, there is the issue in register setting into serial_format().
The issue is that parameter for baudrate setting is initialed zero in this function.
In baudrate is less 9600bps, the issue occurs. In baudrate is over 9600, not occurs. When call serial_baud() before serial_format(), baudrate override and set with an incorrect value.

Therefore, I fixed register setting not to set the parameter of baudrate setting in serial_format().

Fix mistake register setting in serial_format()
Currently, there is the issue in register setting into serial_format().
The issue is that parameter for baudrate setting is initialed zero in this function.
In baudrate  is less 9600bps, the issue occurs. In baudrate  is over 9600, not occurs. When call serial_baud() before serial_format(), baudrate override and set with an incorrect value.

Therefore, I fixed register setting not to set the parameter of baudrate setting in serial_format().
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 10, 2017

/morph test

@0xc0170 0xc0170 added the needs: CI label Mar 10, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 10, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1669

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 10, 2017

@adbridge adbridge merged commit 5495e24 into ARMmbed:master Mar 14, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment